svn commit: r364753 - in head/www/gatling: . files

[Adam Weinberger]

On 13 Aug, 2014, at 11:41, Mathieu Arnold <mat at FreeBSD.org> wrote:

> 
> 
> +--On 13 août 2014 15:28:33 +0000 Alexey Dokuchaev <danfe at FreeBSD.org>
> wrote:
> | On Wed, Aug 13, 2014 at 05:07:43PM +0200, Carlo Strub wrote:
> |> 13/08/2014 05:16 - Vanilla I. Shu wrote:
> |> > New Revision: 364753
> |> > URL: http://svnweb.freebsd.org/changeset/ports/364753
> |> > QAT: https://qat.redports.org/buildarchive/r364753/
> |> > 
> |> > [...]
> |> > -OPTIONS_DEFINE= BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS
> |> > -OPTIONS_DEFAULT= BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS
> |> > +OPTIONS_DEFINE= BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS
> |> > EXAMPLES DEBUG +OPTIONS_SUB= yes
> |> > +OPTIONS_DEFAULT= BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS
> |> > EXAMPLES
> |> 
> |> These large changes, especially the new options, merit a PORTREVISION
> |> bump, no?
> | 
> | No, why?  Default options already include DOCS and EXAMPLES; the above
> | change in OPTIONS_DEFAULT is actually useless.
> 
> OPTIONS_DEFAULT, yes, but they were not present in OPTIONS_DEFINE, thus
> were not there.  There should have been a PORTREVISION bump with this
> change.
> 
> -- 
> Mathieu Arnold
> 

And while you’re bumping PORTREVISION, can you please unmute the installation commands? And put parentheses around your compound commands (cd ${WRKSRC} && ${INSTALL...)

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org