svn commit: r331439 - head/security/checkpassword

[Renato Botelho]

On 28-10-2013 02:54, Alexey Dokuchaev wrote:
> On Wed, Oct 23, 2013 at 10:32:40PM +0000, Renato Botelho wrote:
>> New Revision: 331439
>> URL: http://svnweb.freebsd.org/changeset/ports/331439
>>
>> [...] 
>> -NO_STAGE=	yes
>>  .include <bsd.port.pre.mk>
>> [...] 
>>  .if ${PORT_OPTIONS:MDOCS}
>> -	${MKDIR} ${DOCSDIR}
>> +	${MKDIR} ${STAGEDIR}${DOCSDIR}
>>  .for f in ${PORTDOCS}
>> -	${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
>> +	${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR}
> 
> Since this port is not actually doing something nasty to build those docs,
> you could have simply remove .if ${PORT_OPTIONS:MDOCS} check.  This would
> make the Makefile cleaner, and you and even drop .include <bsd.port.pre.mk>
> (but don't forget to adjust <bsd.port.post.mk> -> <bsd.port.pre.mk>).

What you are proposing is to always intall docs? Even if user has DOCS
option unset?

-- 
Renato Botelho <garga     @ FreeBSD.org>
               <garga.bsd @ gmail.com>
GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 941 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20131028/b1115574/attachment-0001.sig>