svn commit: r330645 - head/audio/audacity

[Tijl Coosemans]

On Sat, 19 Oct 2013 11:31:11 +0000 Alexey Dokuchaev wrote:
> On Thu, Oct 17, 2013 at 05:10:50PM +0200, Tijl Coosemans wrote:
>> On Thu, 17 Oct 2013 14:30:19 +0000 (UTC) Danilo Egea Gondolfo wrote:
>>> Author: danilo
>>> Date: Thu Oct 17 14:30:19 2013
>>> New Revision: 330645
>>> URL: http://svnweb.freebsd.org/changeset/ports/330645
>>> 
>>> Log:
>>>   - Disable SSE if the arch is powerpc [1]
>>>
>>> +.if ${ARCH} == "i386" || ${ARCH} == "powerpc"
>>> +SSE_CFLAGS=	-mno-sse -mno-sse2
>>>  .endif
>> 
>> If this is a problem on powerpc it's probably also a problem on arm,
>> mips, and so on, so maybe it's better to test for ${ARCH} != "amd64"
> 
> Wouldn't checking for MACHINE_CPU:Msse(2) suffice and make eveyone happy?
> SSE are not -specific.

I looked into why the port is trying to use SSE on PowerPC and it looks
like there's a bug in the Makefile: SSE_CONFIGURE_WITH=sse should be
SSE_CONFIGURE_ENABLE=sse.  And "SSE" should be moved from OPTIONS_DEFAULT
to OPTIONS_DEFAULT_amd64.  Then you can remove SSE_CFLAGS everywhere.

The question is if this should be an option at all.  I think it's ok to
just enable SSE on all CPUs that support it like this:

.if ${MACHINE_CPU:Msse}
CONFIGURE_ARGS+=	--enable-sse
.else
CONFIGURE_ARGS+=	--disable-sse
.endif