svn commit: r334796 - head/lang/gcc44

[Gerald Pfeifer]

On Mon, 25 Nov 2013, Mathieu Arnold wrote:
> | +PORTNAME=	gcc47
> |  PORTVERSION=	4.4.7
> 
> You meant gcc44, right ?

Oops, right.  All the full fledged testing unfortunately did not
catch this kind of silly mistake.  Thanks for raising it (and sorry
for committing the fix so quickly that I failed to acknowledge that
in the commit log).

> BTW, why not use PKGNAMESUFFIX= 44 here (and in the other ports) so 
> that you don't have to add distname ?

Bapt asked the same. :-)  Below is what I responded.

FWIW the description of UNIQUENAME does not mention PKGNAMESUFFIX either:

   # UNIQUENAME - A name for your port that is globally unique.  By default,
   #              this is set to ${LATEST_LINK} when LATEST_LINK is set,
   #              and to ${PKGNAMEPREFIX}${PORTNAME} otherwise.

Gerald

==== forwarded message ====
From: Gerald Pfeifer <gerald at pfeifer.com>
Date: Sun, 24 Nov 2013 22:21:19 +0100 (CET)
Subject: Re: Package name collision
:
Looking at it from a distance, it felt a bit wrong to me to have
PORTNAME for lang/gcc48 read gcc, not gcc48.

And Mk/bsd.port.mk did not properly document that.

The latter we can address, of course.  Do you approve the patch
below?

Gerald

Index: bsd.port.mk
===================================================================
--- bsd.port.mk	(revision 334791)
+++ bsd.port.mk	(working copy)
@@ -68,9 +68,11 @@
 #				  Do not define this in your Makefile.
 # PKGNAMEPREFIX	- Prefix to specify that port is language-specific, etc.
 #				  Optional.
-# PKGNAMESUFFIX	- Suffix to specify compilation options.  Optional.
-# PKGVERSION		- Always defined as
-#				  ${PORTVERSION}.
+# PKGNAMESUFFIX	- Suffix to specify compilation options or a version
+#				  designator (in case there are different versions of 
+#				  one port as is the case for Tcl).
+#				  Optional.
+# PKGVERSION	- Always defined as ${PORTVERSION}.
 #				  Do not define this in your Makefile.
 # UNIQUENAME	- A name for your port that is globally unique.  By default,
 #				  this is set to ${LATEST_LINK} when LATEST_LINK is set,