svn commit: r332567 - head/graphics/apvlv

[Eitan Adler]

On Mon, Nov 4, 2013 at 9:15 AM, Mark Felder <feld at freebsd.org> wrote:
>
>
> On Sun, Nov 3, 2013, at 13:38, Eitan Adler wrote:
>> On Sun, Nov 3, 2013 at 2:14 PM, Tijl Coosemans <tijl at freebsd.org> wrote:
>>
>> > but now PTHREAD_CFLAGS is always empty
>>
>> Which is always a mistake.  PTHREAD_CFLAGS should be replaced with
>> -pthread
>>
>>  so you can remove that line and PTHREAD_LIBS is always
>> > -pthread.
>>
>> As should this.
>>
>
> Thanks for the feedback guys. Perhaps we should put PTHREAD_CFLAGS and
> PTHREAD_LIBS into portlint as well.
>
> I'm not 100% sure I understand the changes you're proposing -- I'm
> getting caught up on the wording. Is this diff what you're suggesting?

Yes.



-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams