svn commit: r332635 - head/lang/yap/files

[Danilo E. Gondolfo]

On 11/03/13 17:48, Tijl Coosemans wrote:
> On Sun, 3 Nov 2013 18:11:30 +0000 (UTC) Danilo Egea Gondolfo wrote:
>> Author: danilo
>> Date: Sun Nov  3 18:11:29 2013
>> New Revision: 332635
>> URL: http://svnweb.freebsd.org/changeset/ports/332635
>>
>> Log:
>>   - Fix build with clang on i386
>>
>> Added:
>>   head/lang/yap/files/patch-H__absmi.h   (contents, props changed)
>> Modified:
>>   head/lang/yap/files/patch-library__dialect__swi__fli__blobs.c
>>   head/lang/yap/files/patch-packages__swi-minisat2__C__SolverTypes.h
>>
>> Added: head/lang/yap/files/patch-H__absmi.h
>> ==============================================================================
>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>> +++ head/lang/yap/files/patch-H__absmi.h	Sun Nov  3 18:11:29 2013	(r332635)
>> @@ -0,0 +1,11 @@
>> +--- ./H/absmi.h.orig	2013-11-02 21:11:04.000000000 -0200
>> ++++ ./H/absmi.h	2013-11-02 21:11:12.000000000 -0200
>> +@@ -74,7 +74,7 @@
>> + * Use bp as PREG for X86 machines		               *
>> + ***************************************************************/
>> + #if defined(IN_ABSMI_C)
>> +-register struct yami* P1REG asm ("bp"); /* can't use yamop before Yap.h */
>> ++struct yami* P1REG asm ("bp"); /* can't use yamop before Yap.h */
> 
> Have you runtested this?  Because this expects the ebp register to
> hold the value of P1REG and this change does not guarantee that.
> Clang does not support global register variables at all so if you
> cannot disable this code it has to be compiled with gcc.
> 

You're right. Despite it works with the small programs that I've tested,
I changed the semantics of the code (from this "mov value,%ebp" to this
"movl value,0x8049604". I'll change it to build with GCC.

Thanks for the report.

Danilo.