svn commit: r332334 - in head/finance: . vanitygen

[Ryan Steinmetz]

On (11/01/13 15:24), Boris Samorodov wrote:
>Hi Ryan, All,
>
>01.11.2013 05:12, Ryan Steinmetz пишет:
>
>> Log:
>>   New port: finance/vanitygen:
>
>Thank you for working on new ports. It's always good to get a new one.
>However there are some notes inlined.
>
>> +MAINTAINER=	ports at FreeBSD.org
>
>I'm not sure that a new unmaintained port is welcomed.
>
>> +COMMENT=	A standalone vanity address generator for bitcoin

My bad on this, although, I had thought that portlint(1) would have caught
this.

>
>Articles should not be used at the beginning of a COMMENT.
>
>> +LIB_DEPENDS=	pcre:${PORTSDIR}/devel/pcre
>
>A new LIB_DEPENDS syntax is preferred.
>

Do you have the announcement?  After digging a bit, the only thing I was
able to find was the commit log.

>
>> +NO_STAGE=	yes
>
>I think that new ports are supposed to support STAGE.
>

I do not believe that Tinderbox supports STAGE, so I do not have a means
of testing it at the moment.


-r

>-- 
>WBR, Boris Samorodov (bsam)
>FreeBSD Committer, http://www.FreeBSD.org The Power To Serve

-- 
Ryan Steinmetz
PGP: EF36 D45A 5CA9 28B1 A550  18CD A43C D111 7AD7 FAF2