svn commit: r310063 - in head: . sysutils/cfengine

[Baptiste Daroussin]

On Tue, Jan 08, 2013 at 08:10:49AM +0100, Baptiste Daroussin wrote:
> On Tue, Jan 08, 2013 at 04:33:09AM +0000, Glen Barber wrote:
> > Author: gjb
> > Date: Tue Jan  8 04:33:08 2013
> > New Revision: 310063
> > URL: http://svnweb.freebsd.org/changeset/ports/310063
> > 
> > Log:
> >   Implement the concept of a "master" port for the set of
> >   sysutils/cfengine* ports.
> >   
> >   The idea here is two-fold:
> >   
> >    1.)  Users should not need to ever change port origins
> >         for a default software version bump;
> >    2.)  Users should expect to exist an unversioned port
> >         directory to reflect the latest major version (and
> >         they should be correct in this expectation).
> >   
> >   With this change, users can install the sysutils/cfengine
> >   port, and by default track the latest major version of the
> >   software.  Subsequent version releases, for example the 3.5
> >   branch, will not require any interaction from user side.
> >   
> >   Additionally, users can stay on a certain branch release by
> >   adding, in this case, CFENGINE_VERSION version to make.conf
> >   or specifying the branch during build time with:
> >   
> >   	# make CFENGINE_VERSION=NN
> >   
> >   The list of available CFENGINE_VERSION values are listed
> >   with:
> >   
> >   	# make -V VERSIONS
> >   
> >   Discussed with:		cy
> > 
> 
> Nice! In my opinion this should be followed by all/most? ports with multi
> version in the ports tree, this will fix also fix tracking in binary work major
> upgrades (aka change of default version) with no manuall intervention.
> 
> regards,
> Bapt

While I do like this idea, the implementation is broken: index and package
building is broken now
let me show you why:

# cd /usr/ports/sysutils/cfengine
# make -VPKGNAME -VLATEST_LINK
cfengine-3.4.1
cfengine34
# cd /usr/ports/sysutils/cfengine34
# make -VPKGNAME -VLATEST_LINK
cfengine-3.4.1
cfengine34

and it is forbidden to have 2 exactly same LATEST_LINK and 2 exactly same
PKGNAME

imho the right thing would be in cfengine34 to: define LATEST_LINK only if
!defined(MASTERDIR) and to add PKGNAMESUFFIX=34 if !defined(MASTERDIR)


regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20130108/35075950/attachment.sig>