svn commit: r337389 - head/sysutils/hdup/files

[Tijl Coosemans]

On Thu, 26 Dec 2013 14:34:45 +0100 John Marino wrote:
> On 12/26/2013 14:09, Mathieu Arnold wrote:
>> Hi,
>> 
>> +--On 24 décembre 2013 21:35:54 +0000 John Marino <marino at FreeBSD.org>
>> wrote:
>> | Log:
>> |   sysutils/hdup: Unbreak on FreeBSD 10+
>> |   
>> |   The breakage was caused by processing makefiles with bmake instead of
>> | the   specified gmake.
>> |   
>> |   PR:		ports/184617
>> |   Approved by:	maintainer timeout
>> 
>> Just splitting hairs a bit, here, but, your commit was not approved by
>> anything, to be exact, it should have read more like :
>> 
>> ------
>> sysutils/hdup: Unbreak on FreeBSD 10+
>> 
>> The breakage was caused by processing makefiles with bmake instead of the
>> specified gmake.
>> 
>> maintainer timeout (here an optional number of days/months, if you like)
>> 
>> PR:		ports/184617
> 
> Does it matter?  This is how I did all my commit messages during the
> probation period.  Anyway, I interpret "timeout" as implicit permission
> so I always thought it did apply.

I also use "Approved by: maintainer timeout (N days/weeks/months)".
It makes it clear that approval is normally required.  Not sure where
I picked up this practice though.