svn commit: r307837 - head/comms/morse

Alex Kozlov ak at FreeBSD.org
Tue Nov 27 13:31:09 UTC 2012


On Tue, Nov 27, 2012 at 12:56:10PM +0000, Alexey Dokuchaev wrote:
> On Tue, Nov 27, 2012 at 12:05:04PM +0000, Alex Kozlov wrote:
> > New Revision: 307837
> > URL: http://svnweb.freebsd.org/changeset/ports/307837
> > 
> > +# Created by:	Stephen Hurd <shurd at sasktel.net>
> Space, not tab please.
That's ironic, I even have patch for portlint which adds check for
space afrer Created by/WWW.

> > +OSS_DESC=	Beep using OSS (/dev/dsp)
> > +X11_DESC=	Beep using X server
> > +PA_DESC=	Beep using Pulse Audio
> All of these options are already in bsd.options.desc.mk (PA_DESC is named
> PULSEAUDIO_DESC though).  While you might want to adjust their descriptions,
> at least we should not invent new names for existing features.
I suppose I can change PA_DESC to PULSEAUDIO_DESC, but it's not really matter,
because in this case specific descriptions are better and I'm not going to use
generic ones from bsd.options.desc.mk.


-- 
Alex


More information about the svn-ports-head mailing list