svn commit: r307782 - head/audio/asunder

Guido Falsi madpilot at FreeBSD.org
Mon Nov 26 15:57:35 UTC 2012


On 11/26/12 14:56, Alexey Dokuchaev wrote:
> On Mon, Nov 26, 2012 at 12:59:39PM +0000, Guido Falsi wrote:
>> New Revision: 307782
>> URL: http://svnweb.freebsd.org/changeset/ports/307782
>>
>> -PORTVERSION=	2.0
>> -PORTREVISION?=	2
>> +PORTVERSION=	2.2
>
> Hmm, does this port have slaves?  PORTREVISION?= suggests it does, it this
> case it should be left as PORTREVISION?=0, otherwise it could be overridden
> by slave port(s).

I cannot find any slave ports. I'm inclined to think that the ?= was 
added by mistake in r289243.

>
>> +MONKEYAUDIO_DESC=	Monkey's Audio support
>
> We have standard knob for this one (APE_DESC).
>
>>   PORTDOCS=	AUTHORS COPYING ChangeLog INSTALL NEWS README TODO
>
> Normally we do not install COPYING as part of the docs, LICENSE should be
> set instead.  If software expects to find this file (e.g. for displaying in
> the about dialog), it should be redirected to share/licenses/${PKGNAME}
> instead (see `graphics/luminance' port for an example).
>

Thanks for these, I'll fix them and commit after maintainer approval.

-- 
Guido Falsi <madpilot at FreeBSD.org>


More information about the svn-ports-head mailing list