svn commit: r309705 - in head/irc: . dxirc

[Jason E. Hale]

On Monday, December 31, 2012 03:46:27 Jason Helfman wrote:
> Added: head/irc/dxirc/Makefile
> ============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/irc/dxirc/Makefile     Mon Dec 31 03:46:26 2012        (r309705)
> @@ -0,0 +1,80 @@
>
> +LICENSE=	GPLv3
> +LICENSE_FILE=	${WRKSRC}/COPYING

LICENSE_FILE should be dropped for standard license

> +LIB_DEPENDS=	FOX-1:${PORTSDIR}/x11-toolkits/fox16

The library name is FOX-1.6 despite portlint warnings ".6" is not an ABI 
version number.

> +OPTIONS_DEFINE=	NLS TRAY IPV6 SSL LUA ENCHANT NOTIFY
> +OPTIONS_DEFAULT=	NLS TRAY IPV6 SSL LUA

NLS doesn't need to be in OPTIONS_DEFAULT...it is already default.  Might as 
well add DOCS to OPTIONS_DEFINE too.

> Added: head/irc/dxirc/pkg-plist
> ============================================================================
> == --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/irc/dxirc/pkg-plist	Mon Dec 31 03:46:26 2012	(r309705)
> @@ -0,0 +1,297 @@
> +%%DATADIR%%/COPYING

Since LICENSE is already defined, the installation of an additional license 
file should be squashed.

> + at dirrm share/applications

This should be a @dirrmtry since it is a shared directory.

-- 
Jason E. Hale - jhale@
FreeBSD Ports Committer
KDE/FreeBSD Team