svn commit: r308293 - in head/games: . magicmaze magicmaze/files

Alexey Dokuchaev danfe at FreeBSD.org
Wed Dec 5 01:49:04 UTC 2012


On Wed, Dec 05, 2012 at 12:53:09AM +0000, Jason Helfman wrote:
> New Revision: 308293
> URL: http://svnweb.freebsd.org/changeset/ports/308293
> 
> @@ -0,0 +1,51 @@
> +# Created by: nemysis at gmx.ch
> +#
> +# $FreeBSD$
> +#

This is non-standard header.  Please see official portmgr@ announcement or
other ports that were correctly converted.

> +DESKTOP_ENTRIES="Magic Maze" "${COMMENT}" "${PORTNAME}" \
> +		"${PORTNAME}" "Game;ArcadeGame;" ${FALSE}

fd.org spec requires startup notification be either "true" or "false"; we
should not rely on the fact that make(1) will provide matching names.  I
suggest using plain "false" here (without the quotes).  Yes, I know that
it causes portlint warning; portlint should be patched to handle
DESKTOP_ENTRIES case correctly).

> +.if ${PORT_OPTIONS:MDOCS}
> +	${MKDIR} ${DOCSDIR}
> +	${INSTALL_DATA} ${WRKSRC}/README.TXT ${WRKSRC}/doc/BUGS.TXT ${WRKSRC}/doc/TODO.TXT ${DOCSDIR}

Very long line.  You (or submitter) should have explicitly defined PORTDOCS
and then do something like this:

	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/doc/|} ${DOCSDIR}

./danfe


More information about the svn-ports-head mailing list