svn commit: r566529 - head/x11/foot

Mathieu Arnold mat at freebsd.org
Thu Feb 25 11:50:08 UTC 2021


On Thu, Feb 25, 2021 at 11:30:22AM +0000, Jan Beich wrote:
> +post-patch:	terminfo-patch
> +terminfo-patch:
> +	@${REINPLACE_CMD} '/datadir/s/terminfo/site-&/' ${WRKSRC}/meson.build

This seems overengineered, there is no post-patch target in the
Makefile, so, why create a new target, and hook it up to a non existing
target, instead of just using a regular post-patch target?

If there is a good reason for that, it is not obvious, and the reason
needs to be documented in the Makefile.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20210225/449b93ca/attachment.sig>


More information about the svn-ports-all mailing list