svn commit: r565224 - in head/lang/pocl: . files

[Jason Bacon]

On 2/14/21 7:40 AM, Christoph Moench-Tegeder wrote:
> ## Jason W. Bacon (jwb at FreeBSD.org):
>
>> New Revision: 565224
>> URL: https://svnweb.freebsd.org/changeset/ports/565224
>>
>> Log:
>>    lang/pocl: Update hwloc dependency to hwloc2
> The intention is great, but the execution... has problems.
>
>> -PORTNAME=			pocl
>> +PORTNAME=		pocl
> First, while I'm all in favor of consistent white space, mixing this
> with the stated (per commit message) change makes the diff harder
> to read and "svn annotate" (and similar tools) harder to use later on.
Are you suggesting that whitespace changes should be done in a separate 
commit?
>
>>   BUILD_DEPENDS=	llvm${LLVM_VERSION}>=0:devel/llvm${LLVM_VERSION} \
>> -				opencl>=2.2:devel/opencl
>> -LIB_DEPENDS=	libhwloc.so:devel/hwloc \
>> -				libOpenCL.so:devel/ocl-icd
>> -RUN_DEPENDS=	${BUILD_DEPENDS}
>> +			opencl>=2.2:devel/opencl
>> +LIB_DEPENDS=	libhwloc.so.15:devel/hwloc2 libOpenCL.so:devel/ocl-icd
>> +RUN_DEPENDS=	libhwloc.so.15:devel/hwloc2 libOpenCL.so:devel/ocl-icd
> And this is plain wrong. libhwloc.so.15 and libOpenCL.so are not
> "executables or files this port depends on" - they're libraries and
> belong into LIB_DEPENDS only. At the same time, you dropped that
> llvm from RUN_DEPENDS - now that I look at it closely, I have a hunch
> that the previous "RUN_DEPENDS= ${BUILD_DEPENDS}" wasn't right either
> (would this really need sphinx, cmake and ninja as RUN_DEPENDS?),
> but none of that is even mentioned in the commit message and I
> cannot tell if this was intentional or an accident.
>
> Anyways, the build bombs out in run-depends "pocl-1.6 depends on
> executable: libhwloc.so.15 - not found", which is why I looked at this
> in the first place.
>
Oy...  Not feeling well today but have to push through the pile on my 
desk.  This was some sort of mishap copying the changes after poudriere 
testing elsewhere.  I'll just reverse the RUN_DEPENDS change for now.  
This port needs more work I'm in no shape to do today.

Thanks for the heads-up,

     JB

-- 
Earth is a beta site.