svn commit: r548876 - in branches/2020Q3/www/node: . files

[Bradley T. Hughes]

On Sep 19 2020, at 3:35 am, Dan Langille <dan at langille.org> wrote:

> On Sep 18, 2020, at 12:06 PM, Dan Langille <dan at langille.org> wrote:
>  
>  
>>  
>> On Fri, Sep 18, 2020, at 11:46 AM, Dan Langille wrote:
>>  
>>> www/node will not build on 2020Q3 because of a BUILD_DEPENDS which can
>>> never be met.

URK, I didn't consider this when MFHing all the changes from the past 3
months into www/node (which is often necessary due to the amount of
changes between versions).

>> I have asked permission for the recent archivers/brotli update to
>> 1.0.9 to be MFH seeing as it was security related: https://svnweb.freebsd.org/ports?view=revision&revision=546350
>>  
>> I see now that I did not cc the lists on that email.  Sorry about that.
>  
> Permission received.  r546350 has been mfh into 2020Q3.

Good job, thanks for pick up on the ball on that.

> However, there are other dependencies which are not met on 2020Q3:
>  
> devel/libuv >= 1.39

I will ask to get libuv updated in quarterly as well.

> It appears this commit was never tested on 2020Q3 before being back ported.

Yes, you are correct, I never did test the build on quarterly before
committing :(

> I can't spend more time on this at present, but we've gone from a
> working but vuln port to a non-compiling port.
>  
> It should be reverted.

If I cannot get libuv updated in a timely manner, I will revert. It is
not too long until a new quarterly is cut.  

I am sorry about this, and for not noticing the breakage sooner. :/

>> --
>>  Dan Langille
>>  dan at langille.org<br/><signature id="local-12c221d2-bfa0"><div>
<div>--</div>
<div><strong>Bradley T. Hughes</strong></div>
<div>bhughes at FreeBSD.org</div>
</div></signature>