svn commit: r548168 - in head/graphics/pgplot: . files

[Mathieu Arnold]

On Thu, Sep 10, 2020 at 05:26:20PM +0000, Brooks Davis wrote:
> On Thu, Sep 10, 2020 at 08:09:47AM +0200, Mathieu Arnold wrote:
> > On Wed, Sep 09, 2020 at 11:38:10PM +0000, Brooks Davis wrote:
> > > +LICENSE=	PGPLOT
> > > +LICENSE_NAME=	PGPLOT License
> > > +LICENSE_FILE=	${WRKSRC}/copyright.notice
> > > +LICENSE_PERMS=	no-dist-sell no-pkg-sell
> > 
> > LICENSE_PERMS is a place where you *explicitely* state what a license
> > allows.  The no-xxx components are only useful if you set, say,
> > "dist-sell no-dist-sell", in which case the no-xxx cancels the xxx, and
> > the permission is not set.  If you use the no-xxx component alone, it
> > just gets ignored.  So those perms are equivalent to giving empty
> > permissions, because you are not allowing anything.  In this case, what
> > you probably meant was:
> > 
> > LICENSE_PERMS=	dist-mirror pkg-mirror auto-accept
> 
> Thanks for the correction.  This was not at all what the documentation
> led me to believe.  If the no-* permissions exist so that OPTIONS can
> remove permissions then that should be stated explicitly and they
> probably shouldn't be documented interleaved like they are now.

It is probable that when I wrote the doc, I had absolutely no idea how
it all worked, and I only used what I could gather in the comments from
the code.

Note that you can run `make debug-license` to see how the framework
interpretted what you wrote.

I am still unsure why one would need the no-* permissions exactly, even
if you have multiple licenses, and set the combination to be "multi",
only the components that have been permitted by all licenses will be
allowed, so you do not really need to use the no-* bits.

The only case when they are actually used is if you write:

LICENSE_PERMS=	pkg-sell no-pkg-sell

But I would say that you should probably make up your mind about it and
not write that ;-)

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200911/60babbae/attachment.sig>