svn commit: r543637 - head/net/rsync

[Adam Weinberger]

>> On Jul 28, 2020, at 23:07, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>> 
>> On Tue, Jul 28, 2020 at 11:51:00PM +0000, Adam Weinberger wrote:
>> New Revision: 543637
>> URL: https://svnweb.freebsd.org/changeset/ports/543637
>> Log:
>> rsync: Unbreak and fix depends
>> @@ -19,7 +19,7 @@ LICENSE=    GPLv3
>> LIB_DEPENDS=    libxxhash.so:devel/xxhash \
>>       libzstd.so:archivers/zstd
>> -USES=        cpe shebangfix
>> +USES=        cpe shebangfix ssl
> 
> Is there reason why also adding `localbase' or `localbase:ldflags` here
> on the USES list...
> 
>> +CPPFLAGS+=    -I${LOCALBASE}/include
>> +LDFLAGS+=    -L${LOCALBASE}/lib
> 
> ... rather then explictitly amending these variables was not preferred?

My objective at the time was fixing some build failures. The blanket covers switching to USES, and I definitely encourage you to do so here. Idioms like localbase matter; the more we use them, the more the ports metalanguage evolves.

For the record: The initial intent of USES=localbase wasn’t a simple way for ports to say “-I$LB/include -L$LB/lib”. A long time ago, I recall Baptiste telling people (myself included) to knock it off. I’m sure it’s evolved since then, but I’ve almost never used it since!

# Adam


—
Adam Weinberger
adamw at adamw.org
https://www.adamw.org