svn commit: r542955 - head/archivers/arj

Alexey Dokuchaev danfe at freebsd.org
Fri Jul 24 06:59:02 UTC 2020


On Thu, Jul 23, 2020 at 07:23:58PM +0000, Renato Botelho wrote:
> New Revision: 542955
> URL: https://svnweb.freebsd.org/changeset/ports/542955
> 
> Log:
>   Pet portlint: Declare USES early

This is most definitely a false-positive (as of recently, portlint(1)
mishandles USES) and pessimizes readability by breaking natural flow
of things.  At the very best, you could've moved the USES line above
GNU_CONFIGURE, but placing it between closely related IGNORE_PATCHES
and EXTRA_PATCHES certainly looks bogus.

Please do not blindly trust linters and always check the result from
the human perspective.

./danfe


More information about the svn-ports-all mailing list