svn commit: r541352 - head/audio/libvorbis

[Tijl Coosemans]

On Mon, 6 Jul 2020 17:10:08 +0000 (UTC) Christian Weisgerber
<naddy at FreeBSD.org> wrote:
> Author: naddy
> Date: Mon Jul  6 17:10:08 2020
> New Revision: 541352
> URL: https://svnweb.freebsd.org/changeset/ports/541352
> 
> Log:
>   Use the libtool script from devel/libtool.
>   The included libtool appears to be broken and loses the -lm dependency_lib,
>   so libvorbisenc and libvorbisfile did not get linked with -lm.
>   
>   PR:		247799
> 
> Modified:
>   head/audio/libvorbis/Makefile
> 
> Modified: head/audio/libvorbis/Makefile
> ==============================================================================
> --- head/audio/libvorbis/Makefile	Mon Jul  6 17:02:32 2020	(r541351)
> +++ head/audio/libvorbis/Makefile	Mon Jul  6 17:10:08 2020	(r541352)
> @@ -3,6 +3,7 @@
>  
>  PORTNAME=	libvorbis
>  PORTVERSION=	1.3.7
> +PORTREVISION=	1
>  PORTEPOCH=	3
>  CATEGORIES=	audio
>  MASTER_SITES=	https://downloads.xiph.org/releases/vorbis/ \
> @@ -16,11 +17,13 @@ LICENSE_FILE=	${WRKSRC}/COPYING
>  
>  LIB_DEPENDS=	libogg.so:audio/libogg
>  
> -USES=		libtool pathfix tar:xz
> +# The included libtool is broken and loses the -lm dependency_lib.
> +USES=		libtool:build pathfix tar:xz
>  USE_LDCONFIG=	yes
>  
>  GNU_CONFIGURE=	yes
>  CONFIGURE_ARGS=	--with-ogg=${LOCALBASE}
> +MAKE_ARGS=	LIBTOOL=${PREFIX}/bin/libtool
>  INSTALL_TARGET=	install-strip
>  TEST_TARGET=	check

This is because the bundled libtool is the one from Debian, but it's
also a bad practice to rely on the dependencies of a dependency so a
better fix here would be to add -lm to libvorbisfile_la_LIBADD in
WKRSRC/lib/Makefile.in.  (It doesn't look like libvorbisenc needs libm.)