svn commit: r541296 - in head: databases/kexi devel/injeqt textproc/libkolabxml x11/sddm

Alexey Dokuchaev danfe at freebsd.org
Mon Jul 6 07:43:44 UTC 2020


On Mon, Jul 06, 2020 at 11:25:44AM +0400, Gleb Popov wrote:
> On Mon, Jul 6, 2020 at 1:44 AM Tobias C. Berner <tcberner at freebsd.org>
> wrote:
> 
> > Well, I disagree. I find it exactly the opposite :)
> 
> +1, CMAKE_ON gets parsed by my brain faster than -DBUILD_MAN_PAGES=ON

You've missed the type, it should be -DBUILD_MAN_PAGES:BOOL=ON. :)

Also, CMAKE_ON does not align nicely with <option>_CMAKE_ON which gets
added to CMAKE_ARGS as is.  This inconsistency alone bothers me enough
to avoid using CMAKE_ON.

./danfe


More information about the svn-ports-all mailing list