svn commit: r541296 - in head: databases/kexi devel/injeqt textproc/libkolabxml x11/sddm

Alexey Dokuchaev danfe at freebsd.org
Sun Jul 5 19:26:42 UTC 2020


On Sun, Jul 05, 2020 at 07:20:21PM +0000, Tobias C. Berner wrote:
> New Revision: 541296
> URL: https://svnweb.freebsd.org/changeset/ports/541296
> 
> Log:
>   Switch to using CMAKE_ON/CMAKE_OFF instead of more clunky CMAKE_ARGS
> 
> Modified: head/x11/sddm/Makefile
> ...
> +CMAKE_ON=	BUILD_MAN_PAGES
>  CMAKE_ARGS=	-DUID_MIN=1000 \
>  		-DUID_MAX=65000 \
>  		-DCMAKE_INSTALL_SYSCONFDIR:PATH=${LOCALBASE}/etc \
> -		-DBUILD_MAN_PAGES=ON \
>  		-DRST2MAN_EXECUTABLE=${LOCALBASE}/bin/rst2man.py-${PYTHON_VER}

This one looks like pessimization.  Please be more considerate with these
changes; I, for one, do not like CMAKE_ON/OFF as I find it harder to read
and understand and prefer explicit assignments via CMAKE_ARGS.

./danfe


More information about the svn-ports-all mailing list