svn commit: r540489 - in head/devel/fhist: . files

Gerald Pfeifer gerald at pfeifer.com
Thu Jul 2 11:36:47 UTC 2020


On Fri, 26 Jun 2020, Mathieu Arnold wrote:
> We want patches that apply cleanly, without patch having to randonly
> decide where it is going to put the different hunks.

And indeed below you'll find a very real example.  

(I *was* aware, and had prepared removal of that patch, alas made a
mistake and the tree I committed from lacked the `svn delete`.  And
patch(1) simply applied a patch again that was already there.)


On Fri, 26 Jun 2020, Kyle Evans wrote:
> In my ideal world, the ports tree would run with -F0 because it's
> absolutely nonsensical to let it look like it might have done the
> right thing.

+1.  Would you like to propose a patch and trigger an -exp run?
(Or maybe as a first step go down from the default -F2 to -F1?)

Gerald

====== recent commit ======
Author: gerald
Date: Thu Jul  2 11:24:58 2020
New Revision: 541034
URL: https://svnweb.freebsd.org/changeset/ports/541034

Log:
  Really remove files/patch-dlls_ntdll (a temporary build fix) that I
  noted, but missed, in r539797.
  
  This patch still applied, leading to duplication of the hunk in
  question, which was benign though.

Deleted:
  head/emulators/wine-devel/files/patch-dlls_ntdll


More information about the svn-ports-all mailing list