svn commit: r540967 - in head/net/lualdap: . files

[Li-Wen Hsu]

On Wed, Jul 1, 2020 at 11:59 PM Alexey Dokuchaev <danfe at freebsd.org> wrote:
>
> On Wed, Jul 01, 2020 at 10:28:15AM -0500, Jason Bacon wrote:
> > On 2020-07-01 10:16, Alexey Dokuchaev wrote:
> > > On Wed, Jul 01, 2020 at 02:06:12PM +0000, Li-Wen Hsu wrote:
> > >> New Revision: 540967
> > >> URL: https://svnweb.freebsd.org/changeset/ports/540967
> > >>
> > >> Log:
> > >>    Update to 1.2.5
> > >>
> > >> ...
> > >> -MAKE_ARGS+=       LUA_LIBDIR="${LUA_LIBDIR}" \
> > >> -          LUA_INC="${LUA_INCDIR}" \
> > >> -          OPENLDAP_LIB="-L${LOCALBASE}/lib -lldap" \
> > >> -          LUA_VERSION_NUM="${LUA_VER_STR}0" \
> > >> -          CC="${CC}"
> > >> +MAKE_ARGS+=       CPPFLAGS="-I${LOCALBASE}/include -I${LUA_INCDIR}" \
> > >> +          LDFLAGS="-L${LOCALBASE}/lib" \
> > >> +          CC=${CC}
> > > Dropping quotes around ${CC} can potentially break things and also
> > > had contributed some unnecessary repo churn. :(
> >
> > I would have thought ${CC} is always just the compiler name sans
> > flags/whitespace, but danfe is correct. There's one case in Mk that
> > would call for quotes:
>
> Another thing which rings the bell is ccache which can be invoked as
> "ccache compiler [compiler options]", thus CC="ccache compiler".

Nice catch! Thanks and fixed in r540974.

Li-Wen