svn commit: r540967 - in head/net/lualdap: . files

[Jason Bacon]

On 2020-07-01 10:16, Alexey Dokuchaev wrote:
> On Wed, Jul 01, 2020 at 02:06:12PM +0000, Li-Wen Hsu wrote:
>> New Revision: 540967
>> URL: https://svnweb.freebsd.org/changeset/ports/540967
>>
>> Log:
>>    Update to 1.2.5
>>    
>> ...
>> -MAKE_ARGS+=	LUA_LIBDIR="${LUA_LIBDIR}" \
>> -		LUA_INC="${LUA_INCDIR}" \
>> -		OPENLDAP_LIB="-L${LOCALBASE}/lib -lldap" \
>> -		LUA_VERSION_NUM="${LUA_VER_STR}0" \
>> -		CC="${CC}"
>> +MAKE_ARGS+=	CPPFLAGS="-I${LOCALBASE}/include -I${LUA_INCDIR}" \
>> +		LDFLAGS="-L${LOCALBASE}/lib" \
>> +		CC=${CC}
> Dropping quotes around ${CC} can potentially break things and also
> had contributed some unnecessary repo churn. :(
>
> ./danfe
I would have thought ${CC} is always just the compiler name sans 
flags/whitespace, but danfe is correct.  There's one case in Mk that 
would call for quotes:

FreeBSD coral.acadix  bacon ~ 1004: grep -r  ^CC=  /usr/ports/Mk/
[snip]
/usr/ports/Mk/bsd.port.mk:CC=           ${XCC} --sysroot=${CROSS_SYSROOT}

-- 
Earth is a beta site.