svn commit: r556857 - head/databases/memcached

[Steve Wills]

Hi,

Right, I was saying they are OK but you need to have an "Approved by:" 
line just to be clear.

Steve

On 12/3/20 12:20 PM, Piotr Kubaj wrote:
> Thanks for feedback, I just assumed that trivial patches for Tier 2 architectures that have no way of affecting Tier 1 are ok.
> 
> On 20-12-02 22:28:30, Steve Wills wrote:
>> Hi,
>>
>> No objection here, happy to see this actually, but this needed a PR and
>> approval or at the least a "Approved by: tier 2 blanket" line.
>>
>> Steve
>>
>> On 12/2/20 5:03 PM, Piotr Kubaj wrote:
>>> Author: pkubaj
>>> Date: Wed Dec  2 22:03:47 2020
>>> New Revision: 556857
>>> URL: https://svnweb.freebsd.org/changeset/ports/556857
>>>
>>> Log:
>>>     databases/memcached: enable DTRACE on powerpc64 head
>>>     
>>>     -no-integrated-as is ommitted, since as can't build the compiler-generated code. memcached nevertheless builds.
>>>
>>> Modified:
>>>     head/databases/memcached/Makefile
>>>
>>> Modified: head/databases/memcached/Makefile
>>> ==============================================================================
>>> --- head/databases/memcached/Makefile	Wed Dec  2 21:48:25 2020	(r556856)
>>> +++ head/databases/memcached/Makefile	Wed Dec  2 22:03:47 2020	(r556857)
>>> @@ -3,6 +3,7 @@
>>>    
>>>    PORTNAME=	memcached
>>>    PORTVERSION=	1.6.8
>>> +PORTREVISION=	1
>>>    CATEGORIES=	databases
>>>    MASTER_SITES=	http://www.memcached.org/files/ \
>>>    		GENTOO
>>> @@ -33,6 +34,11 @@ OPTIONS_DEFINE=		DOCS SASL
>>>    OPTIONS_DEFAULT=	SASL
>>>    OPTIONS_DEFINE_amd64=	DTRACE
>>>    OPTIONS_DEFAULT_amd64=	DTRACE
>>> +OPTIONS_DEFINE_powerpc64=	DTRACE
>>> +OPTIONS_DEFAULT_powerpc64=	DTRACE
>>> +OPTIONS_EXCLUDE_powerpc64=	${OPTIONS_EXCLUDE_${ARCH}_${OSREL:R}}
>>> +OPTIONS_EXCLUDE_powerpc64_11=	DTRACE
>>> +OPTIONS_EXCLUDE_powerpc64_12=	DTRACE
>>>    
>>>    .if !exists(/usr/sbin/dtrace)
>>>    OPTIONS_EXCLUDE+=	DTRACE
>>> @@ -61,12 +67,12 @@ CONFIGURE_ARGS+=	--enable-tls
>>>    USES+=			ssl
>>>    .endif
>>>    
>>> -.if ${ARCH} == amd64
>>> +.if ${ARCH} == amd64 || ${ARCH} == powerpc64
>>>    CONFIGURE_ARGS+=	--enable-64bit
>>>    .endif
>>>    
>>>    # avoid triggering a bug in libdtrace, see illumos issue 6653
>>> -.if ${PORT_OPTIONS:MDTRACE}
>>> +.if ${PORT_OPTIONS:MDTRACE} && ${ARCH} == amd64
>>>    CFLAGS+=	-no-integrated-as
>>>    .endif
>>>    
>>>