svn commit: r501839 - head/www/py-websocket-client

[Kubilay Kocak]

On 17/05/2019 6:22 pm, Antoine Brodin wrote:
> Author: antoine
> Date: Fri May 17 08:22:27 2019
> New Revision: 501839
> URL: https://svnweb.freebsd.org/changeset/ports/501839
> 
> Log:
>    Unbreak at runtime
>    
>    Pointy hat:	koobs
> 
> Modified:
>    head/www/py-websocket-client/Makefile
> 
> Modified: head/www/py-websocket-client/Makefile
> ==============================================================================
> --- head/www/py-websocket-client/Makefile	Fri May 17 08:00:59 2019	(r501838)
> +++ head/www/py-websocket-client/Makefile	Fri May 17 08:22:27 2019	(r501839)
> @@ -3,6 +3,7 @@
>   
>   PORTNAME=	websocket-client
>   PORTVERSION=	0.56.0
> +PORTREVISION=	1
>   CATEGORIES=	www python
>   MASTER_SITES=	CHEESESHOP
>   PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
> @@ -24,7 +25,13 @@ USE_PYTHON=	distutils concurrent autoplist
>   
>   NO_ARCH=	yes
>   
> +.include <bsd.port.pre.mk>
> +
> +.if ${PYTHON_REL} < 3500
> +RUN_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}backports.ssl_match_hostname>0:security/py-backports.ssl_match_hostname@${PY_FLAVOR}
> +.endif
> +
>   do-test:
>   	@cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
>   
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
> 

Thanks Antoine, but what was the actual error observed?

I QA'd this pretty thoroughly (including a full test suite run/pass) so 
it would be handy to know the exact failure mode

Python > 2.7.9 has match_hostname and websocket-client checks for the 
stdlib before falling back to backports:

        if hasattr(ssl, "match_hostname"):
             from ssl import match_hostname
         else:
             from backports.ssl_match_hostname import match_hostname