svn commit: r495326 - in head/textproc/kibana6: . files

[Koichiro Iwao]

On Mon, Mar 11, 2019 at 07:32:31AM +0100, Tobias Kortkamp wrote:
> > @@ -35,14 +35,17 @@ do-install:
> >  		${RM} -r config node optimize && \
> >  		${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR})
> >  	${INSTALL} -lrs ${STAGEDIR}${ETCDIR} ${STAGEDIR}${WWWDIR}/config
> > -	${CHMOD} +x ${STAGEDIR}${WWWDIR}/bin/*
> >  
> >  post-install:
> >  	${ECHO} "@sample ${ETCDIR}/kibana.yml.sample" >> ${TMPPLIST}
> >  	${FIND} -s ${STAGEDIR}${WWWDIR} -not -type d | ${SORT} | \
> >  		${SED} -e 's#^${STAGEDIR}${PREFIX}/##' >> ${TMPPLIST}
> > +	${REINPLACE_CMD} -e "s|\(${WWWDIR}/bin/.*\)|@mode 0755 \1|" ${TMPPLIST}
> 
> I'm sorry, but this is probably wrong and a noop.  There are no
> entries starting with WWWDIR in TMPPLIST (${PREFIX} is stripped
> from entries in the ${FIND} line above it).  I guess it should be
> WWWDIR_REL here.  @mode also does not take a file argument.  Though
> that problem is of course never triggered.  See pkg-create(8):

Indeed, thanks. I meant WWWDIR_REL here but I wasn't aware it is noop.
Alternatively, I think COPYTREE_BIN or INSTALL_PROGRAM is another
option.

> What was wrong with using CHMOD?

Actually nothing's going wrong but portlint warned. I aporogize for over
optimization.

-- 
meta <meta at FreeBSD.org>