svn commit: r495007 - in head/devel: . llvm

[Brooks Davis]

On Fri, Mar 08, 2019 at 07:50:39PM +0100, Jan Beich wrote:
> Brooks Davis <brooks at freebsd.org> writes:
> 
> > On Fri, Mar 08, 2019 at 06:03:55AM -0700, Adam Weinberger wrote:
> >
> >> On Thu, Mar 7, 2019 at 5:41 PM Brooks Davis <brooks at freebsd.org> wrote:
> >> >
> >> >   It is intended for use by users and should not be a port build dependency.
> >> 
> >> Perhaps a comment near the top of the Makefile about this could be
> >> helpful. Right now there's nothing in the Makefile or pkg-descr to
> >> inform future porters of this important implementation detail.
> >
> > What I'd really like is a way to declare a port as ineligible to be a
> > dependency.
> 
> Like the following?
> 
> $ DEVELOPER=1 make check-sanity
> /!\ foo-0.1: Makefile errors /!\
> 
> devel/llvm in BUILD_DEPENDS is unsupported, please use devel/llvm60 instead
> 
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/ports/misc/foo
> 
> --- Mk/bsd.sanity.mk.orig
> +++ Mk/bsd.sanity.mk
> @@ -70,6 +70,14 @@ DEV_WARNING+=	"Not validating first entry in CATEGORIES due to being outside of
>  DEV_ERROR+=	"USE_PERL5=yes is unsupported, please use USES=perl5 instead"
>  .endif
>  
> +.if !empty(BUILD_DEPENDS:M*devel/llvm)
> +DEV_ERROR+=	"devel/llvm in BUILD_DEPENDS is unsupported, please use devel/llvm${LLVM_DEFAULT} instead"
> +.endif
> +
> +.if !empty(BUILD_DEPENDS:M*lang/gcc)
> +DEV_ERROR+=	"lang/gcc in BUILD_DEPENDS is unsupported, please use USE_GCC=yes instead"
> +.endif
> +
>  .if !empty(LIB_DEPENDS:M*/../*)
>  DEV_ERROR+=	"LIB_DEPENDS contains unsupported relative path to dependency"
>  .endif
> 

I'd like something like:

LEAF_PORT_BUILD=	Ports should depend on explict devel/llvm## ports
LEAF_PORT_LIB=		Ports should depend on explict devel/llvm## ports

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190308/9acfa313/attachment.sig>