svn commit: r494654 - head/devel/googletest
Enji Cooper
ngie at FreeBSD.org
Mon Mar 4 21:51:54 UTC 2019
Author: ngie (src committer)
Date: Mon Mar 4 21:51:53 2019
New Revision: 494654
URL: https://svnweb.freebsd.org/changeset/ports/494654
Log:
devel/googletest: require libpthread
As noted by @asomers in rS300906 (`cddl/usr.sbin/zfsd/tests/Makefile`
specifically), googletest requires libpthread in order to function, if
`-DGTEST_HAS_PTHREAD` is defined.
While this is true, the code was not being linked against libpthread,
resulting in libgtest being broken, and thus all tests reliant on the library
broken at runtime.
Adding `LIBS+= -lpthread` unbreaks the tests that use pthread support
internally.
PR: 236169
Reviewed by: jbeich
Approved by: jbeich (maintainer)
Differential Revision: https://reviews.freebsd.org/D19463
Modified:
head/devel/googletest/Makefile
Modified: head/devel/googletest/Makefile
==============================================================================
--- head/devel/googletest/Makefile Mon Mar 4 21:47:09 2019 (r494653)
+++ head/devel/googletest/Makefile Mon Mar 4 21:51:53 2019 (r494654)
@@ -4,7 +4,7 @@
PORTNAME= googletest
DISTVERSIONPREFIX= release-
DISTVERSION= 1.8.1
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= devel
MAINTAINER= jbeich at FreeBSD.org
@@ -25,6 +25,12 @@ CONFIGURE_ENV= ac_cv_path_PYTHON=":"
TEST_TARGET= check
INSTALL_TARGET= install-strip
USE_LDCONFIG= yes
+
+# googletest requires pthread in order to function and does not properly
+# detect pthread support.
+#
+# See: https://github.com/google/googletest/issues/2162
+LIBS+= -lpthread
post-patch:
# enable vendor make install again (revert 661758e)
More information about the svn-ports-all
mailing list