svn commit: r506329 - head/multimedia/libva

[Jan Beich]

Steve Wills <swills at FreeBSD.org> writes:

> Hi,
>
> On 7/16/19 2:27 PM, Jan Beich wrote:
>>
>> Yep. Old -CURRENT/-STABLE snapshots were never supported[1]. Bug 238650
>> references commits for each branch.
>>
>> [1] in terms of security fixes, binary packages and, by extension,
>>      building from source
>>
>
> Checking __FreeBSD_version would be a simpler change and avoid
> this. It wasn't bumped for this particular change, but 1300033 is
> probably close enough, no?

Did you miss the base change was MFC'd to several /stable branches?
What you propose would break declarative style in favor of unwieldy
conditional where snapshot ranges aren't tested by the package cluster.
When to garbage-collect it also becomes less clear.

.if (${OPSYS} == FreeBSD && (${OSVERSION} < 1103501 || \
    (${OSVERSION} >= 1200000 && ${OSVERSION} < 1200513) || \
    (${OSVERSION} >= 1300000 && ${OSVERSION} < 1300034)))
LDFLAGS+=	-lpthread
.endif

Why do you care so much about -CURRENT snapshots with known vulnerabilities?
If you simply don't have time/resources to upgrade -CURRENT jails why not
locally revert the offending commit.