svn commit: r506432 - in head: audio/libcoverart audio/nekobi-lv2 benchmarks/netperfmeter chinese/pyzy comms/ncid databases/postgis25 games/diaspora graphics/gimmage graphics/pcl-pointclouds graphi...

[Jan Beich]

Mark Linimon <linimon at lonesome.com> writes:

> On Fri, Jul 12, 2019 at 05:55:41AM +0200, Jan Beich wrote:
>
>> Mark Linimon <linimon at FreeBSD.org> writes:
>> 
>> > -.if exists(/usr/lib/libstdc++.so)
>> > +
>> > +.include <bsd.port.pre.mk>
>> > +
>> > +.if ${CHOSEN_COMPILER_TYPE} == gcc
>> >  CXXFLAGS+=	-stdlib=libstdc++
>> >  .endif
>> 
>> Which version of GCC supports -stdlib= flag?
>
> Note that didn't change the line that specifies CXXFLAGS, just the test
> around it.

CHOSEN_COMPILER_TYPE is always "clang" due to USES=objc:compiler but
Clang defaults to libc++ since FreeBSD 10.0. So, your commit probably
broke libobjc2 runtime on GCC-based architectures.

// From contrib/llvm/tools/clang/lib/Driver/ToolChains/FreeBSD.cpp:
ToolChain::CXXStdlibType FreeBSD::GetDefaultCXXStdlibType() const {
  if (getTriple().getOSMajorVersion() >= 10)
    return ToolChain::CST_Libcxx;
  return ToolChain::CST_Libstdcxx;
}