svn commit: r479538 - in head: Mk audio/clementine-player audio/dpf-plugins-lv2 audio/gogglesmm audio/mixxx audio/rhythmbox audio/x42-plugins-lv2 cad/brlcad cad/freecad cad/kicad cad/kicad-devel ca...

[Gerald Pfeifer]

On Wed, 12 Sep 2018, Matthew D. Fuller wrote:
>> Log:
>>   Change x11/xorgproto to become a build dep
>>   [...]
>>   Bump portrevision on depending ports.
> At least x11-servers/xorg-{nestserver,vfbserver} and
> x11-servers/xwayland have a .include of xorg-server/Makefile at the
> end, which means that their PORTREVISIONs went backward (from 9 to 1)
> as a result of this.  Since they'll just get it from xorg-server, they
> wouldn't need PORTREVISION added anyway.
> 
> (it might be worth a comment in the Makefiles where the PORTREVISION
> would be, to add a little guardrail for the future)

Agreed.  Or, as I see is now the case with x11-servers/xwayland (Thanks!), 
though not x11-servers/xorg-{nestserver,vfbserver} simply add their own 
PORTREVISION.

PORTREVISION bumps sometimes touch a thousand, or two thousand, or even 
more ports, and anything that's intricate or easy to miss unfortunately 
does fare a chance of a mishap taking place.


The logic I added to Tools/scripts/bump-revision.sh last year to catch 
cases of PORTREVISION practically going backwards is a great safety net, 
but as always: better for a safety net not being used in the first place. 
;-)

Gerald