svn commit: r491675 - in head/comms/fldigi: . files

[Kyle Evans]

On Thu, Jan 31, 2019 at 8:10 AM Alexey Dokuchaev <danfe at freebsd.org> wrote:
>
> On Thu, Jan 31, 2019 at 08:37:32AM -0500, Diane Bruce wrote:
> > On Thu, Jan 31, 2019 at 02:14:39AM +0000, Alexey Dokuchaev wrote:
> > > ...
> > > These two patches were essentially not changed and should have been
> > > dropped from the commit batch to reduce repo churn and diff noise.
> >
> > Tell that to the make makepatch maintainers please.
>
> Well, no: makepatch would never (and it's not supposed to) be so smart
> to detect/mitigate these things.  Evaluating a diff (and commit hygiene
> in general) is committer's responsibility.
>

It's worth noting that I added some bits [1] to makepatch to try and
help reduce some churn by blatantly ignoring new patches that resulted
in only change to the timestamp.

I think there's no reason this couldn't grow the ability to ignore
changes like the ones you pointed out if you make sure it's still
sensitive to the line offset information -- I think we should be
making some level of effort to keep line numbers reflective of the
current code-base to minimize effort required in identifying the block
and verifying correctness of the patch.

Thanks,

Kyle Evans

[1] https://svnweb.freebsd.org/ports?view=revision&revision=459675