svn commit: r491209 - head/deskutils/recoll

[Mathieu Arnold]

On Fri, Jan 25, 2019 at 11:08:24PM +0000, Yuri Victorovich wrote:
> Author: yuri
> Date: Fri Jan 25 23:08:24 2019
> New Revision: 491209
> URL: https://svnweb.freebsd.org/changeset/ports/491209
> 
> Log:
>   deskutils/recoll: Update 1.23.7 -> 1.24.3
>   
>   * New dependency of QT5. Remove all references to QT4
>   * Add gnome to USES
>   * Shebang file desktop/hotrecoll.py moved to filters/hotrecoll.py
>   * Portlint suggestions:
>       USE_LDCONFIG=yes
>       USE_GL+=gl when QT5 options is enabled

So, let me remind you.  A commit message is about *WHY* you are doing
the things you are doing.  NEVER about WHAT you are doing.  Anyone can
read a diff, see that you removed Qt4 in favor of Qt5, added stuff to
USES, changed a line here and ther, so documenting this does not help
anyone.

What you need to document is WHY you are doing the changes, so that
someone reading the diff understands the reason behind the changes.

Here, the commit message may have looked like:

  Update to 1.24.3

  Switch from Qt4 to Qt5 and removed deprecation.
  Fix some QA warnings.

And that's it.  All other changes are related to updating the port or
cleaning things up a bit.

> @@ -70,9 +70,9 @@ X11MON_CONFIGURE_WITH=	fam
>  X11MON_BROKEN=		does not build: index/rclmonrcv.cpp:(.text+0x1f13): undefined reference to `FAMOpen2'
>  
>  .include <bsd.port.options.mk>
> -.if ${PORT_OPTIONS:MQT4}
> -DEPRECATED=		Qt4 has been EOL since december 2015
> -EXPIRATION_DATE=	2019-03-15
> +
> +.if ${PORT_OPTIONS:MQT5}
> +USE_GL+=gl
>  .endif

QT5_USE=   gl+=gl

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190126/c693caaa/attachment.sig>