svn commit: r490566 - head/security/libgpg-error

[Alexey Dokuchaev]

On Thu, Jan 17, 2019 at 07:22:44PM +0400, Roman Bogorodskiy wrote:
> > On Thu, Jan 17, 2019 at 03:10:27PM +0000, Roman Bogorodskiy wrote:
> > > New Revision: 490566
> > > URL: https://svnweb.freebsd.org/changeset/ports/490566
> > > 
> > > Log:
> > >   security/libgpg-error: update to 1.34
> > >   
> > >   Also, move USES to pet portlint.
> > > 
> > > ...
> > > @@ -14,10 +14,11 @@ LICENSE_COMB=	multi
> > >  LICENSE_FILE_GPLv2=	${WRKSRC}/COPYING
> > >  LICENSE_FILE_LGPL21=	${WRKSRC}/COPYING.LIB
> > >  
> > > +USES=		gmake libtool tar:bzip2
> > > +
> > >  OPTIONS_DEFINE=	DOCS NLS
> > >  OPTIONS_SUB=	yes
> > >  
> > > -USES=		gmake libtool tar:bzip2
> > >  USE_LDCONFIG=		yes
> > >  GNU_CONFIGURE=		yes
> > 
> > Looks like you should've moved the OPTIONS block instead.
> 
> Yes, just checked PH, you're correct. Though portlint didn't
> complain about that.

portlint(1) is just a mere linter, it can catch simple mistakes but
situations when entire block is misplaced is out of its scope.

> I'll fix it with the next update.

Thanks; it is a minor issue and does not warrant a separate commit.

./danfe