svn commit: r508657 - head/biology/gperiodic

[Baptiste Daroussin]

On Sun, Aug 11, 2019 at 05:29:10PM +0000, Kurt Jaeger wrote:
> Author: pi
> Date: Sun Aug 11 17:29:10 2019
> New Revision: 508657
> URL: https://svnweb.freebsd.org/changeset/ports/508657
> 
> Log:
>   biology/gperiodic: upgrade 2.0.10 -> 3.0.3
>   
>   - new mastersite

I am not sure this has been really reviewed before it has been committed, see
the comments inline below.

Bapt

>   
>   PR:		239642
>   Submitted by:	Walter Schwarzenfeld <w.schwarzenfeld at utanet.at>
>   Relnotes:	https://sourceforge.net/p/gperiodic/code/HEAD/tree/branches/3.0.3/ChangeLog
> 
> Modified:
>   head/biology/gperiodic/Makefile
>   head/biology/gperiodic/distinfo
>   head/biology/gperiodic/pkg-plist
> 
> Modified: head/biology/gperiodic/Makefile
> ==============================================================================
> --- head/biology/gperiodic/Makefile	Sun Aug 11 17:10:07 2019	(r508656)
> +++ head/biology/gperiodic/Makefile	Sun Aug 11 17:29:10 2019	(r508657)
> @@ -3,10 +3,9 @@
>  #    $MCom: ports/biology/gperiodic/Makefile,v 1.1 2006/09/29 23:42:13 ahze Exp $
>  
>  PORTNAME=	gperiodic
> -PORTVERSION=	2.0.10
> -PORTREVISION=	8
> +PORTVERSION=	3.0.3
>  CATEGORIES=	biology
> -MASTER_SITES=	http://www.frantz.fi/software/
> +MASTER_SITES=	https://sourceforge.net/projects/gperiodic/files/
>  
>  MAINTAINER=	ports at FreeBSD.org
>  COMMENT=	Displays a periodic table of the elements
> @@ -14,15 +13,13 @@ COMMENT=	Displays a periodic table of the elements
>  LICENSE=	GPLv2+
>  LICENSE_FILE=	${WRKSRC}/gpl.txt
>  
> -BROKEN=		unfetchable
> -
> -USE_GNOME=	gtk20
>  USES=		pkgconfig
> +USE_GNOME=	gtk20
>  
> -LANGS=		da fr gl it pl ru sv tr
> -
>  PORTDOCS=	AUTHORS ChangeLog README
>  
> +LANGS=		be cs da de es fi fr gl is it ms pl pt ru sv tr uk zh_CN
> +
>  OPTIONS_DEFINE=	DOCS NLS
>  OPTIONS_SUB=	yes
>  
> @@ -39,9 +36,7 @@ do-build-NLS-on:
>  
>  do-install:
>  	${INSTALL_PROGRAM} ${WRKSRC}/gperiodic ${STAGEDIR}${PREFIX}/bin
> -	${INSTALL_DATA} ${WRKSRC}/gperiodic.desktop \
> -		${STAGEDIR}${PREFIX}/share/applications
> -	(cd ${WRKSRC} && ${INSTALL_DATA} gperiodic.png gperiodic-crystal.png \
> +	(cd ${WRKSRC}/icons && ${INSTALL_DATA} gperiodic-crystal.png gperiodic.png \
>  		${STAGEDIR}${PREFIX}/share/pixmaps)
>  
>  do-install-NLS-on:
> @@ -50,6 +45,13 @@ do-install-NLS-on:
>  	${INSTALL_DATA} ${WRKSRC}/po/${lang}.mo \
>  		${STAGEDIR}${PREFIX}/share/locale/${lang}/LC_MESSAGES/${PORTNAME}.mo
>  .endfor
> +	${MKDIR} ${STAGEDIR}${PREFIX}/share/locale/gperiodic
> +	${INSTALL_DATA} ${WRKSRC}/table_data.h \
> +		${STAGEDIR}${PREFIX}/share/locale/gperiodic
> +	${INSTALL_DATA} ${WRKSRC}/po/gperiodic.pot \
> +		${STAGEDIR}${PREFIX}/share/locale/gperiodic
> +	${INSTALL_DATA} ${WRKSRC}/po/README \
> +		${STAGEDIR}/${PREFIX}/share/locale/gperiodic	

Those new lines are installing things in the locale directory which does not
belong to the share/locale directory!
>  
>  do-install-DOCS-on:
>  	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> 
> Modified: head/biology/gperiodic/distinfo
> ==============================================================================
> --- head/biology/gperiodic/distinfo	Sun Aug 11 17:10:07 2019	(r508656)
> +++ head/biology/gperiodic/distinfo	Sun Aug 11 17:29:10 2019	(r508657)
> @@ -1,2 +1,3 @@
> -SHA256 (gperiodic-2.0.10.tar.gz) = 78d72870c51c39e4a35c804c05b8ef5e39f88d42eced52b2934e21d74fb8d096
> -SIZE (gperiodic-2.0.10.tar.gz) = 131213
> +TIMESTAMP = 1564926393
> +SHA256 (gperiodic-3.0.3.tar.gz) = 5e70128f61a311bd6b4ad129bd726ccc0e3731573cb0050201293e2a5389b29a
> +SIZE (gperiodic-3.0.3.tar.gz) = 451559
> 
> Modified: head/biology/gperiodic/pkg-plist
> ==============================================================================
> --- head/biology/gperiodic/pkg-plist	Sun Aug 11 17:10:07 2019	(r508656)
> +++ head/biology/gperiodic/pkg-plist	Sun Aug 11 17:29:10 2019	(r508657)
> @@ -1,12 +1,25 @@
> + at postexec chmod -R 770 /usr/local/share/locale/gperiodic
^^
This should never ever be done, why do you think it is necessary to do it here?
>  bin/gperiodic
> -share/applications/gperiodic.desktop
> -%%NLS%%share/locale/da/LC_MESSAGES/gperiodic.mo
> -%%NLS%%share/locale/fr/LC_MESSAGES/gperiodic.mo
> -%%NLS%%share/locale/gl/LC_MESSAGES/gperiodic.mo
> -%%NLS%%share/locale/it/LC_MESSAGES/gperiodic.mo
> -%%NLS%%share/locale/pl/LC_MESSAGES/gperiodic.mo
> -%%NLS%%share/locale/ru/LC_MESSAGES/gperiodic.mo
> -%%NLS%%share/locale/sv/LC_MESSAGES/gperiodic.mo
> -%%NLS%%share/locale/tr/LC_MESSAGES/gperiodic.mo
> -share/pixmaps/gperiodic.png
> +share/locale/be/LC_MESSAGES/gperiodic.mo
> +share/locale/cs/LC_MESSAGES/gperiodic.mo
> +share/locale/da/LC_MESSAGES/gperiodic.mo
> +share/locale/de/LC_MESSAGES/gperiodic.mo
> +share/locale/es/LC_MESSAGES/gperiodic.mo
> +share/locale/fi/LC_MESSAGES/gperiodic.mo
> +share/locale/fr/LC_MESSAGES/gperiodic.mo
> +share/locale/gl/LC_MESSAGES/gperiodic.mo
> +share/locale/gperiodic/README
> +share/locale/gperiodic/gperiodic.pot
> +share/locale/gperiodic/table_data.h
> +share/locale/is/LC_MESSAGES/gperiodic.mo
> +share/locale/it/LC_MESSAGES/gperiodic.mo
> +share/locale/ms/LC_MESSAGES/gperiodic.mo
> +share/locale/pl/LC_MESSAGES/gperiodic.mo
> +share/locale/pt/LC_MESSAGES/gperiodic.mo
> +share/locale/ru/LC_MESSAGES/gperiodic.mo
> +share/locale/sv/LC_MESSAGES/gperiodic.mo
> +share/locale/tr/LC_MESSAGES/gperiodic.mo
> +share/locale/uk/LC_MESSAGES/gperiodic.mo
> +share/locale/zh_CN/LC_MESSAGES/gperiodic.mo

The %%NLS has been removed, meaning the port is now broken with the NLS option
set to off.

>  share/pixmaps/gperiodic-crystal.png
> +share/pixmaps/gperiodic.png
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190823/fde1fc86/attachment.sig>