svn commit: r481210 - head/lang/ghc

Baptiste Daroussin bapt at FreeBSD.org
Thu Oct 4 12:22:24 UTC 2018


On Thu, Oct 04, 2018 at 01:14:02PM +0300, Gleb Popov wrote:
> On Thu, Oct 4, 2018 at 12:02 PM Alexey Dokuchaev <danfe at freebsd.org> wrote:
> 
> > On Thu, Oct 04, 2018 at 08:34:09AM +0000, Gleb Popov wrote:
> > > New Revision: 481210
> > > URL: https://svnweb.freebsd.org/changeset/ports/481210
> > >
> > > Log:
> > >   lang/ghc: Remove BOOTH option.
> >
> > This is very bad commit message.  Please always try to exlain the changes
> > made, not simply translate the diff into English.  Your mentor should have
> > told you that.
> >
> > ./danfe
> >
> 
> An explanation in the Phab Diff isn't sufficient?


No the explaination should be first in the commit logs which is what we all face
at first

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181004/d2ab6bc1/attachment.sig>


More information about the svn-ports-all mailing list