svn commit: r485493 - in head/misc: . sdformat sdformat/files

Yuri yuri at freebsd.org
Wed Nov 21 03:42:04 UTC 2018


On 11/20/18 6:43 PM, Jan Beich wrote:
> Why not just add TEST option and run after build when enabled?
>
>    OPTIONS_DEFINE=    TEST
>
>    TEST_CMAKE_BOOL=    BUILD_TESTING
>    TEST_TEST_TARGET=    test
>
>    pre-install-TEST-on: do-test
>

Because the option will remain in the package. Once installed, the TEST 
option has no meaning. With TEST=on or TEST=off the package is exactly 
the same, which defeats the meaning of the option.

On the other hand, with the custom 'do-test' target only the test target 
is added without any extra port options.


Yuri



More information about the svn-ports-all mailing list