svn commit: r484041 - head/devel/heimdall

[Alexey Dokuchaev]

On Mon, Nov 05, 2018 at 11:16:23AM +0100, Mathieu Arnold wrote:
> On Mon, Nov 05, 2018 at 06:01:32AM +0000, Alexey Dokuchaev wrote:
> > On Sun, Nov 04, 2018 at 05:29:18PM +0000, Mark Linimon wrote:
> > > On Sun, Nov 04, 2018 at 03:13:15PM +0000, Alexey Dokuchaev wrote:
> > > > I don't understand, why not just fix the code by removing offending
> > > > part:
> > > 
> > > portsjail% grep -v "#" ../analysis/clang6_regressions.work | wc -l
> > >      261
> > > 
> > > Fixing 261 ports is more than one person can do IMVVHO.
> > 
> > Okay, but I'm talking about one particular port (which is maintained,
> > so one might expect that maintainer has some knowledge of the code)
> > and I've attached a patch.  I believe it is quite doable by one person
> > in this very case. :-)
> 
> Once again, you fail to understand that it is not the job of portmgr to
> fix all the broken things, it is to curate the ports tree.

I understand that Mathieu.

> If we find a simple fix, like here, we do that

My point exactly; I didn't imply that someone(tm) should go down the
entire logstash and relentlessly try to fix the code no matter what.
Good that we agree.  This, like you've correctly put, was a simple,
easy to find fix (committed in r484179 FWIW).

./danfe