svn commit: r483807 - in head: Mk Mk/Uses audio/kwave audio/logitechmediaserver audio/supercollider audio/teamspeak3-server audio/wavpack audio/zynaddsubfx base/binutils cad/calculix cad/linuxcnc-d...

[Emanuel Haupt]

On 11/3/18 1:22 PM, Gerald Pfeifer wrote:
> On Fri, 2 Nov 2018, Rene Ladan wrote:
>> URL: https://svnweb.freebsd.org/changeset/ports/483807
>>
>> Log:
>>   Remove compatibility code for FreeBSD < 11.2 from all ports.
>>   
>>   Simplify some ports where DragonFlyBSD no longer needs to be special-cased.
>>   Submitted by:	rene
>>   Reviewed by:	bapt, jbeich
>>   Differential Revision:	https://reviews.freebsd.org/D17724
> 
>> Modified: head/cad/openscad/Makefile
>> ==============================================================================
>> -#.if ${ARCH} == i386 && ${OSVERSION} >= 1100000
>> +#.if ${ARCH} == i386
>>  #USE_GCC=        yes
>>  #.endif
> 
> Yes, but this was dead code before and is still dead code.
> 
> Okay to remove this, Michael?
> 
>> Modified: head/devel/heimdall/Makefile
>> ==============================================================================
>>  # does not compile with clang 6.0.0
>> -.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1101513
>> +.if ${OPSYS} == FreeBSD
>>  USE_GCC=	yes
>>  .endif
> 
> Yes, but shouldn't the .if simple be removed now?
> 
> Okay, to do so, Emanuel?

Yes, with 10.x being out of the picture it should be removed and
USE_GCC=yes be moved up to the USE* block. Feel free to commit.

Emanuel

>> Modified: head/devel/libzim/Makefile
> ============================================================================
>> # Using gcc6 and libstdc++ leads to error because xapian-core is linked with libc++
>> -BROKEN_FreeBSD_10=     /usr/include/c++/v1/memory:4004:35: error: no viable overloaded '='
> 
> That comment now became obsolete, so I went ahead and remove it
> (revision 483889).  Hope you're fine, Steve.
> 
> Gerald
>