svn commit: r470615 - head

[Tijl Coosemans]

On Thu, 24 May 2018 14:45:50 +0200 Mathieu Arnold <mat at FreeBSD.org> wrote:
> On Tue, May 22, 2018 at 04:02:46PM +0200, Tijl Coosemans wrote:
>> On Tue, 22 May 2018 13:58:34 +0000 (UTC) Mathieu Arnold <mat at FreeBSD.org> wrote:  
>>> Author: mat
>>> Date: Tue May 22 13:58:33 2018
>>> New Revision: 470615
>>> URL: https://svnweb.freebsd.org/changeset/ports/470615
>>> 
>>> Log:
>>>   Don't tell people to use @${FLAVOR} in that case, it's bad practice.
>>>   
>>>   Sponsored by:	Absolight
>>> 
>>> Modified:
>>>   head/CHANGES
>>> 
>>> Modified: head/CHANGES
>>> ==============================================================================
>>> --- head/CHANGES	Tue May 22 13:58:03 2018	(r470614)
>>> +++ head/CHANGES	Tue May 22 13:58:33 2018	(r470615)
>>> @@ -152,8 +152,7 @@ AUTHOR: mat at FreeBSD.org
>>>  
>>>    In all the ports with Python dependencies, the *_DEPENDS entries MUST end
>>>    with the flavor so that the framework knows which to build/use.  This is done
>>> -  by appending '@${PY_FLAVOR}' after the origin (or @${FLAVOR} if in a Python
>>> -  module with Python flavors, as the content will be the same).  For example:
>>> +  by appending '@${PY_FLAVOR}' after the origin.  For example:
>>>  
>>>      RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR}  
>> 
>> There are still some dependencies under Mk/ without @${PY_FLAVOR}.  
>
> I cannot find any, can you be less vague? (or better, just fix them.)
> 

Some lines that look suspicious:

bsd.gstreamer.mk:python_DEPENDS=	multimedia/py-gstreamer
bsd.wx.mk:_WX_PORT_python_2.8=	x11-toolkits/py-wxPython28
bsd.wx.mk:_WX_PORT_python_3.0=	x11-toolkits/py-wxPython30
Uses/gnome.mk:pygobject_BUILD_DEPENDS=	pygobject-codegen-2.0:devel/py-gobject
Uses/gnome.mk:pygobject_RUN_DEPENDS=		pygobject-codegen-2.0:devel/py-gobject
Uses/gnome.mk:pygtk2_BUILD_DEPENDS=	${LOCALBASE}/libdata/pkgconfig/pygtk-2.0.pc:x11-toolkits/py-gtk2
Uses/gnome.mk:pygtk2_RUN_DEPENDS=	${LOCALBASE}/libdata/pkgconfig/pygtk-2.0.pc:x11-toolkits/py-gtk2
Uses/gnome.mk:pygnome2_BUILD_DEPENDS=	${LOCALBASE}/libdata/pkgconfig/gnome-python-2.0.pc:x11-toolkits/py-gnome2
Uses/gnome.mk:pygnome2_RUN_DEPENDS=	${LOCALBASE}/libdata/pkgconfig/gnome-python-2.0.pc:x11-toolkits/py-gnome2
Uses/gnome.mk:pygtksourceview_BUILD_DEPENDS=	${LOCALBASE}/libdata/pkgconfig/pygtksourceview-2.0.pc:x11-toolkits/py-gtksourceview
Uses/gnome.mk:pygtksourceview_RUN_DEPENDS=	${LOCALBASE}/libdata/pkgconfig/pygtksourceview-2.0.pc:x11-toolkits/py-gtksourceview
Uses/kde.mk:pykde4_PORT=		devel/py-pykde4-kde4
Uses/kde.mk:pykdeuic4_PORT=		devel/py-pykdeuic4-kde4