svn commit: r472896 - in head/sysutils: . ssd_report

[Bryan Drewery]

On 6/20/2018 11:31 AM, Devin Teske wrote:
> Author: dteske
> Date: Wed Jun 20 18:31:47 2018
> New Revision: 472896
> URL: https://svnweb.freebsd.org/changeset/ports/472896
> 
> Log:
>   [New Port] sysutils/ssd_report
>   
>   Report SSD health by looking at SMART data. Supports `smartctl' from
>   sysutils/smartmontools but prefers `smart' from sysutils/smart. Also
>   supports JSON output upon request.
>   
>   Reviewed by:	mat (mentor)
>   Approved by:	portmgr (mat), mat (mentor)
>   Sponsored by:	Smule, Inc.
>   Differential Revision:	https://reviews.freebsd.org/D15876
> 
> Added:
>   head/sysutils/ssd_report/
>   head/sysutils/ssd_report/Makefile   (contents, props changed)
>   head/sysutils/ssd_report/distinfo   (contents, props changed)
>   head/sysutils/ssd_report/pkg-descr   (contents, props changed)
> Modified:
>   head/sysutils/Makefile
> 
> Modified: head/sysutils/Makefile
> ==============================================================================
> --- head/sysutils/Makefile	Wed Jun 20 18:25:02 2018	(r472895)
> +++ head/sysutils/Makefile	Wed Jun 20 18:31:47 2018	(r472896)
> @@ -1202,6 +1202,7 @@
>      SUBDIR += spinner
>      SUBDIR += spiped
>      SUBDIR += squashfs-tools
> +    SUBDIR += ssd_report
>      SUBDIR += sshsudo
>      SUBDIR += ssid
>      SUBDIR += ssync
> 
> Added: head/sysutils/ssd_report/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/ssd_report/Makefile	Wed Jun 20 18:31:47 2018	(r472896)
> @@ -0,0 +1,36 @@
> +# $FreeBSD$
> +
> +PORTNAME=	ssd_report
> +DISTVERSION=	0.2
> +CATEGORIES=	sysutils
> +
> +MAINTAINER=	dteske at FreeBSD.org
> +COMMENT=	SSD health report
> +
> +LICENSE=	BSD2CLAUSE
> +LICENSE_FILE=	${WRKSRC}/LICENSE
> +
> +FLAVORS=	smart smartmontools

FLAVORS requires that each flavor has a unique PKGNAME because *every
version of the package* will be built and stored on the package
repository. It can't work to have 2 packages with the same name that
have different functionality. So you must handle PKGNAMESUFFIX here
somehow for at least the non-default flavors.

smartmontools_PKGNAMESUFFIX= -smartmontools


> +FLAVOR?=	${FLAVORS:[1]}

Why put FLAVOR? here? It is not needed. FLAVOR is a user-specified
option that already has a default in bsd.port.mk.

> +
> +smart_RUN_DEPENDS=		smart:sysutils/smart
> +smartmontools_RUN_DEPENDS=	smartctl:sysutils/smartmontools
> +
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	FrauBSD
> +NO_ARCH=	yes
> +NO_BUILD=	yes
> +
> +PLIST_FILES=	sbin/ssd_report
> +PORTDOCS=	README.md
> +
> +OPTIONS_DEFINE=	DOCS
> +
> +do-install:
> +	${INSTALL_SCRIPT} ${WRKSRC}/ssd_report ${STAGEDIR}${PREFIX}/sbin
> +
> +do-install-DOCS-on:
> +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> +	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
> +
> +.include <bsd.port.mk>
> 
> Added: head/sysutils/ssd_report/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/ssd_report/distinfo	Wed Jun 20 18:31:47 2018	(r472896)
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1529303779
> +SHA256 (FrauBSD-ssd_report-0.2_GH0.tar.gz) = a56a76277dc095ef24dd954447e6ad86140838308e667d6143a84202a8c17f2c
> +SIZE (FrauBSD-ssd_report-0.2_GH0.tar.gz) = 7715
> 
> Added: head/sysutils/ssd_report/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/ssd_report/pkg-descr	Wed Jun 20 18:31:47 2018	(r472896)
> @@ -0,0 +1,5 @@
> +Report SSD health by looking at SMART data. Supports `smartctl' from
> +sysutils/smartmontools but prefers `smart' from sysutils/smart. Also
> +supports JSON output upon request.
> +
> +WWW: https://fraubsd.org/ssd_report/
> 


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180620/f45da3ce/attachment.sig>