svn commit: r472343 - branches/2018Q2/devel/git-review

[Mathieu Arnold]

On Wed, Jun 13, 2018 at 06:33:24PM -0300, Joseph Mingrone wrote:
> Mathieu Arnold <mat at FreeBSD.org> writes:
> 
> > On Wed, Jun 13, 2018 at 08:58:12PM +0000, Joseph Mingrone wrote:
> >> Author: jrm
> >> Date: Wed Jun 13 20:58:12 2018
> >> New Revision: 472343
> >> URL: https://svnweb.freebsd.org/changeset/ports/472343
> 
> >> Log:
> >>   MFH: r472342
> 
> >>   devel/git-review/Makefile: Update to version 1.26.0
> 
> >>   PR:		226100
> >>   Submitted by:	w.schwarzenfeld at utanet.at
> >>   Reported by:    erj
> >>   Approved by:	dereckson at gmail.com (maintainer)
> 
> >>   Approved by:	portmgr (implicit)
> 
> > I just went back to read [1], and looking at the patch, and the commit
> > message, I highly doubt any of the items in the blanket approval list
> > match.
> 
> > 1: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-qa-blanket
> 
> Did you read
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226100#c0?
> 
> That sounds like "Build, runtime or packaging fixes, if the quarterly
> branch version is currently broken." to me.
> 
> I probably should have noted that in the commit message.

Well, no, I did not go have a look at the PR, never will, a commit
message should stand by itself, especially if you are claiming some
special privileges along with it.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180614/2a517f8e/attachment.sig>