svn commit: r471272 - head/Mk/Scripts

[Mathieu Arnold]

On Mon, Jun 04, 2018 at 10:18:17AM +0000, Alexey Dokuchaev wrote:
> On Fri, Jun 01, 2018 at 04:20:48PM +0000, Mathieu Arnold wrote:
> > New Revision: 471272
> > URL: https://svnweb.freebsd.org/changeset/ports/471272
> > 
> > Log:
> >   SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
> >   
> >   cd can fail for a variety of reasons: misspelled paths, missing
> >   directories, missing permissions, broken symlinks and more.
> 
> That's why I'd typically use 'set -e' as a safety net in case I forgot
> to handle some command's failure.

Yes, note it is only in qa.sh that this was needed, because it is the
only one without `set -e`.  From what I remember, using it was not
possible, I do not remember the details though. Feel free to audit the
script to figure out if it is still the case.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180604/0e54bd47/attachment-0001.sig>