svn commit: r471403 - head/databases/qt5-sqldrivers-mysql/files
Adriaan de Groot
adridg at FreeBSD.org
Sat Jun 2 20:22:17 UTC 2018
Author: adridg
Date: Sat Jun 2 20:22:16 2018
New Revision: 471403
URL: https://svnweb.freebsd.org/changeset/ports/471403
Log:
Comment on patch for databases/qt5-sqldrivers-mysql
Add a note to the patch for MariaDB-compatibility on how to do it
without ifdefs, which therefore would track changes in MariaDB
definitions (if it follows the MySQL change) automatically.
Modified:
head/databases/qt5-sqldrivers-mysql/files/patch-src_plugins_sqldrivers_mysql_qsql__mysql.cpp
Modified: head/databases/qt5-sqldrivers-mysql/files/patch-src_plugins_sqldrivers_mysql_qsql__mysql.cpp
==============================================================================
--- head/databases/qt5-sqldrivers-mysql/files/patch-src_plugins_sqldrivers_mysql_qsql__mysql.cpp Sat Jun 2 20:05:45 2018 (r471402)
+++ head/databases/qt5-sqldrivers-mysql/files/patch-src_plugins_sqldrivers_mysql_qsql__mysql.cpp Sat Jun 2 20:22:16 2018 (r471403)
@@ -10,6 +10,13 @@ now requires a C++ or C99 compiler to compile.
(Bug #25597667)
+For Qt5, which requires C++11, the following line single-line
+definition for mysql_bool is less-fragile and more C++y:
+ using mysql_bool = decltype(MYSQL_BIND::is_null_value);
+This does not apply to the Qt4 port, which allows older compilers
+and the less-fragile approach would therefore break on old-gcc-in-base
+architectures.
+
--- src/plugins/sqldrivers/mysql/qsql_mysql.cpp.orig 2018-04-29 07:25:09 UTC
+++ src/plugins/sqldrivers/mysql/qsql_mysql.cpp
@@ -74,6 +74,14 @@ Q_DECLARE_METATYPE(MYSQL_STMT*)
More information about the svn-ports-all
mailing list