svn commit: r471271 - head/Mk/Scripts
Mathieu Arnold
mat at FreeBSD.org
Fri Jun 1 16:20:49 UTC 2018
Author: mat
Date: Fri Jun 1 16:20:45 2018
New Revision: 471271
URL: https://svnweb.freebsd.org/changeset/ports/471271
Log:
SC2153: Possible misspelling: PORTNAME may not be assigned, but portname is.
ShellCheck has noticed that you reference a variable that is not
assigned in the script, which has a name remarkably similar to one that
is explicitly assigned. You should verify that the variable name is
spelled correctly.
PR: 227109
Submitted by: mat
Sponsored by: Absolight
Modified:
head/Mk/Scripts/qa.sh (contents, props changed)
Modified: head/Mk/Scripts/qa.sh
==============================================================================
--- head/Mk/Scripts/qa.sh Fri Jun 1 16:20:42 2018 (r471270)
+++ head/Mk/Scripts/qa.sh Fri Jun 1 16:20:45 2018 (r471271)
@@ -818,6 +818,9 @@ gemdeps()
{
rc=0
if [ "${PKGBASE%%-*}" = "rubygem" ]; then
+ # shellcheck disable=SC2153
+ # In the heredoc, ${PORTNAME} comes from the environment, not
+ # to be confused with ${portname}
while read -r l; do
if [ -n "${l}" ]; then
name=${l%% *}
More information about the svn-ports-all
mailing list