svn commit: r475335 - head/devel/liteide
Yuri
yuri at freebsd.org
Thu Jul 26 07:16:36 UTC 2018
On 7/26/18 12:08 AM, Alexey Dokuchaev wrote:
> Yes, I know, but as long as you never check against the default FLAVOR,
> you don't need it.
>
>>> Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
>>> in .else branch) and never for .if ${FLAVOR} == qt5.
>> Framework checks that flavor is in the list. Here, when flavor isn't
>> qt4, it is safe to assume that it is qt5.
> Thank you captain. Not sure why you had to explain this, but that does
> not change the point that you don't need FLAVOR?=${FLAVORS:[1]}. :U
> will protect you from undefined variable, and it would be defined in the
> Qt4 case because it's not the default flavor.
I think it's conceptually simpler to have this line, so that FLAVOR is
always defined after it.
This line increases readability and understandability, IMO.
Yuri
More information about the svn-ports-all
mailing list