svn commit: r474520 - head/x11-clocks/glclock

[Tobias Kortkamp]

On Thu, Jul 12, 2018, at 16:11, Dmitry Marakasov wrote:
> Author: amdmi3
> Date: Thu Jul 12 14:11:46 2018
> New Revision: 474520
> URL: https://svnweb.freebsd.org/changeset/ports/474520
> 
> Log:
>   - Fix build with clang 6
> 
> Modified:
>   head/x11-clocks/glclock/Makefile
> 
> Modified: head/x11-clocks/glclock/Makefile
> ==============================================================================
> --- head/x11-clocks/glclock/Makefile	Thu Jul 12 14:11:30 2018	(r474519)
> +++ head/x11-clocks/glclock/Makefile	Thu Jul 12 14:11:46 2018	(r474520)
> @@ -15,6 +15,7 @@ USE_GL=		gl glu glut
>  MAKEFILE=	makefile
>  
>  CFLAGS+=	-DIMAGE_PATH="\\\"${PREFIX}/lib/X11/glclock/\\\""
> +CXXFLAGS+=	-Wno-c++11-narrowing

Why is this needed after r474251?  Was the previous fix not enough?
Can you include a copy of the errors this fixes in the commit message
and/or maybe add a link to the build failure log?

Besides that this breaks the build on Tier 2 archs like powerpc.
gcc 4.2 doesn't recognize -Wno-c++11-narrowing and treats it as an
error:

cc1plus: error: unrecognized command line option "-Wno-c++11-narrowing"

I think something like

USES=		compiler
CXXFLAGS+=	${CXXFLAGS_${CHOSEN_COMPILER_TYPE}}
CXXFLAGS_clang=	-Wno-c++11-narrowing

or similar would be better.

>  
>  PLIST_FILES=	${PROGRAMS:S,^,bin/,} ${SCRIPTS:S,^,bin/,} \
>  		${TEXTURES:S,^,lib/X11/glclock/,}
>