svn commit: r473793 - in head/devel: . cwrap nss_wrapper pam_wrapper resolv_wrapper socket_wrapper uid_wrapper

Tue Jul 3 06:58:45 UTC 2018

On Tue, Jul 03, 2018 at 03:29:43AM +0000, Timur I. Bakeyev wrote:
> Added: head/devel/nss_wrapper/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/nss_wrapper/Makefile	Tue Jul  3 03:29:42 2018	(r473793)
> @@ -0,0 +1,37 @@
> +# $FreeBSD$
> +
> +PORTNAME=		nss_wrapper
> +PORTVERSION=		1.1.3
> +CATEGORIES=		devel
> +MASTER_SITES=		SAMBA/cwrap
> +
> +MAINTAINER=		timur at FreeBSD.org
> +COMMENT=		Wrapper for the user, group and hosts NSS API
> +
> +LICENSE=		GPLv3
> +
> +USES=			cmake:outsource perl5 shebangfix
> +USE_PERL5=		run
> +USE_LDCONFIG=		yes
> +
> +CMAKE_ARGS+=		-DMAN_INSTALL_DIR:PATH="${PREFIX}/man"

Why +=?

> +OPTIONS_DEFINE=		TEST
> +OPTIONS_DEFAULT=	TEST
> +
> +TEST_TARGET=		test

Fun fact, TEST_TARGET may not do what you think it does.  What it does
is tell the framework that the target to run when running `make test` is
test, which will probably fail if the TEST option is not enabled.  What
you may have meant to set was TEST_TEST_TARGET, which sets TEST_TARGET
when the TEST option is enabled.

> +TEST_CMAKE_BOOL=	UNIT_TESTING
> +TEST_BUILD_DEPENDS+=	cmocka>=1.1.1:sysutils/cmocka

Why +=?

> +SHEBANG_FILES=		nss_wrapper.pl
> +
> +PLIST_FILES=		bin/nss_wrapper.pl \
> +			libdata/pkgconfig/nss_wrapper.pc \
> +			lib/cmake/nss_wrapper/nss_wrapper-config-version.cmake \
> +			lib/cmake/nss_wrapper/nss_wrapper-config.cmake \
> +			lib/libnss_wrapper.so.0.2.3 \
> +			lib/libnss_wrapper.so.0 \
> +			lib/libnss_wrapper.so \
> +			man/man1/nss_wrapper.1.gz

These are a lot of files, you should probably be using a pkg-plist file
instead.

> Added: head/devel/pam_wrapper/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/pam_wrapper/Makefile	Tue Jul  3 03:29:42 2018	(r473793)
> @@ -0,0 +1,47 @@
> +# $FreeBSD$
> +
> +PORTNAME=		pam_wrapper
> +PORTVERSION=		1.0.6
> +CATEGORIES=		devel
> +MASTER_SITES=		SAMBA/cwrap
> +
> +MAINTAINER=		timur at FreeBSD.org
> +COMMENT=		Preloadable wrapper to test PAM applications and PAM Modules
> +
> +LICENSE=		GPLv3
> +
> +USES=			cmake:outsource python:2.7+
> +USE_LDCONFIG=		yes
> +
> +CMAKE_ARGS+=		-DMAN_INSTALL_DIR:PATH="${PREFIX}/man"

Why +=?

> +OPTIONS_DEFINE=		TEST
> +OPTIONS_DEFAULT=	TEST
> +
> +TEST_TARGET=		test

Same remark.

> +TEST_CMAKE_BOOL=	UNIT_TESTING
> +TEST_BUILD_DEPENDS+=	cmocka>=1.1.1:sysutils/cmocka

Why +=?

> +PLIST_FILES=		libdata/pkgconfig/pam_wrapper.pc \
> +			libdata/pkgconfig/libpamtest.pc \
> +			lib/cmake/pam_wrapper/pam_wrapper-config-version.cmake \
> +			lib/cmake/pam_wrapper/pam_wrapper-config.cmake \
> +			lib/cmake/libpamtest/libpamtest-config.cmake \
> +			lib/cmake/libpamtest/libpamtest-config-version.cmake \
> +			lib/libpam_wrapper.so.0.0.3 \
> +			lib/libpam_wrapper.so.0 \
> +			lib/libpam_wrapper.so \
> +			lib/libpamtest.so.0.0.3 \
> +			lib/libpamtest.so.0 \
> +			lib/libpamtest.so \
> +			lib/pam_wrapper/pam_matrix.so \
> +			lib/pam_wrapper/pam_get_items.so \
> +			lib/pam_wrapper/pam_set_items.so \
> +			${PYTHON_SITELIBDIR}/pypamtest.so \
> +			include/libpamtest.h \
> +			man/man1/pam_wrapper.1.gz \
> +			man/man8/pam_matrix.8.gz \
> +			man/man8/pam_get_items.8.gz \
> +			man/man8/pam_set_items.8.gz

Way too many files to be using PLIST_FILES, please use a pkg-plist file.

> Added: head/devel/resolv_wrapper/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/resolv_wrapper/Makefile	Tue Jul  3 03:29:42 2018	(r473793)
> @@ -0,0 +1,33 @@
> +# $FreeBSD$
> +
> +PORTNAME=		resolv_wrapper
> +PORTVERSION=		1.1.5
> +CATEGORIES=		devel
> +MASTER_SITES=		SAMBA/cwrap
> +
> +MAINTAINER=		timur at FreeBSD.org
> +COMMENT=		Wrapper for dns name resolving or dns faking
> +
> +LICENSE=		GPLv3
> +
> +USES=			cmake:outsource
> +USE_LDCONFIG=		yes
> +
> +CMAKE_ARGS+=		-DMAN_INSTALL_DIR:PATH="${PREFIX}/man"

Why +=?

> +OPTIONS_DEFINE=		TEST
> +OPTIONS_DEFAULT=	TEST
> +
> +TEST_TARGET=		test

Same.

> +TEST_CMAKE_BOOL=	UNIT_TESTING
> +TEST_BUILD_DEPENDS+=	cmocka>=1.1.1:sysutils/cmocka

Why +=?

> +PLIST_FILES=		libdata/pkgconfig/resolv_wrapper.pc \
> +			lib/cmake/resolv_wrapper/resolv_wrapper-config-version.cmake \
> +			lib/cmake/resolv_wrapper/resolv_wrapper-config.cmake \
> +			lib/libresolv_wrapper.so.0.0.5 \
> +			lib/libresolv_wrapper.so.0 \
> +			lib/libresolv_wrapper.so \
> +			man/man1/resolv_wrapper.1.gz

Same.

> Added: head/devel/socket_wrapper/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/socket_wrapper/Makefile	Tue Jul  3 03:29:42 2018	(r473793)
> @@ -0,0 +1,37 @@
> +# $FreeBSD$
> +
> +PORTNAME=		socket_wrapper
> +PORTVERSION=		1.1.9
> +CATEGORIES=		devel
> +MASTER_SITES=		SAMBA/cwrap
> +
> +MAINTAINER=		timur at FreeBSD.org
> +COMMENT=		Library passing all socket communications through unix sockets
> +
> +LICENSE=		GPLv3
> +
> +USES=			cmake:outsource
> +USE_LDCONFIG=		yes
> +
> +CMAKE_ARGS+=		-DMAN_INSTALL_DIR:PATH="${PREFIX}/man"

Why +=?

> +OPTIONS_DEFINE=		TEST
> +OPTIONS_DEFAULT=	TEST
> +
> +TEST_TARGET=		test

Same.

> +TEST_CMAKE_BOOL=	UNIT_TESTING
> +TEST_BUILD_DEPENDS+=	cmocka>=1.1.1:sysutils/cmocka

Why +=?

> +PLIST_FILES=		libdata/pkgconfig/socket_wrapper.pc \
> +			lib/cmake/socket_wrapper/socket_wrapper-config-version.cmake \
> +			lib/cmake/socket_wrapper/socket_wrapper-config.cmake \
> +			lib/libsocket_wrapper.so.0.1.9 \
> +			lib/libsocket_wrapper.so.0 \
> +			lib/libsocket_wrapper.so \
> +			man/man1/socket_wrapper.1.gz

Same.

> Added: head/devel/uid_wrapper/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/uid_wrapper/Makefile	Tue Jul  3 03:29:42 2018	(r473793)
> @@ -0,0 +1,33 @@
> +# $FreeBSD$
> +
> +PORTNAME=		uid_wrapper
> +PORTVERSION=		1.2.4
> +CATEGORIES=		devel
> +MASTER_SITES=		SAMBA/cwrap
> +
> +MAINTAINER=		timur at FreeBSD.org
> +COMMENT=		Wrapper to fake privilege separation
> +
> +LICENSE=		GPLv3
> +
> +USES=			cmake:outsource
> +USE_LDCONFIG=		yes
> +
> +CMAKE_ARGS+=		-DMAN_INSTALL_DIR:PATH="${PREFIX}/man"

Why +=?

> +OPTIONS_DEFINE=		TEST
> +OPTIONS_DEFAULT=	TEST
> +
> +TEST_TARGET=		test

Same.

> +TEST_CMAKE_BOOL=	UNIT_TESTING
> +TEST_BUILD_DEPENDS+=	cmocka>=1.1.1:sysutils/cmocka

Why +=?

> +PLIST_FILES=		libdata/pkgconfig/uid_wrapper.pc \
> +			lib/cmake/uid_wrapper/uid_wrapper-config-version.cmake \
> +			lib/cmake/uid_wrapper/uid_wrapper-config.cmake \
> +			lib/libuid_wrapper.so.0.0.6 \
> +			lib/libuid_wrapper.so.0 \
> +			lib/libuid_wrapper.so \
> +			man/man1/uid_wrapper.1.gz

Same.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180703/ffb4a601/attachment.sig>